[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41934: reverse-region no longer works
From: |
Richard Copley |
Subject: |
bug#41934: reverse-region no longer works |
Date: |
Thu, 18 Jun 2020 18:59:21 +0100 |
On Thu, 18 Jun 2020 at 18:52, Richard Copley <rcopley@gmail.com> wrote:
> On Thu, 18 Jun 2020 at 18:42, Eli Zaretskii <eliz@gnu.org> wrote:
> Thanks,
> No, that fails on this example [...]
How's this?
diff --git a/lisp/sort.el b/lisp/sort.el
index de0e1b9519..f878db24a3 100644
--- a/lisp/sort.el
+++ b/lisp/sort.el
@@ -554,9 +554,6 @@ is the one that ends before END."
(if (> beg end)
(let (mid) (setq mid end end beg beg mid)))
(save-excursion
- (when (or (< (line-beginning-position) beg)
- (< end (line-end-position)))
- (user-error "There are no full lines in the region"))
;; Put beg at the start of a line and end and the end of one --
;; the largest possible region which fits this criteria.
(goto-char beg)
@@ -568,6 +565,8 @@ is the one that ends before END."
;; reversal; it isn't difficult to add it afterward.
(or (and (eolp) (not (bolp))) (progn (forward-line -1) (end-of-line)))
(setq end (point-marker))
+ (when (<= end beg)
+ (user-error "There are no full lines in the region"))
;; The real work. This thing cranks through memory on large regions.
(let (ll (do t))
(while do
- bug#41934: reverse-region no longer works, Richard Copley, 2020/06/18
- bug#41934: reverse-region no longer works, Eli Zaretskii, 2020/06/18
- bug#41934: reverse-region no longer works, Richard Copley, 2020/06/18
- bug#41934: reverse-region no longer works,
Richard Copley <=
- bug#41934: reverse-region no longer works, Eli Zaretskii, 2020/06/18
- bug#41934: reverse-region no longer works, Richard Copley, 2020/06/18
- bug#41934: reverse-region no longer works, Eli Zaretskii, 2020/06/18
- Message not available
- bug#41934: reverse-region no longer works, Eli Zaretskii, 2020/06/19
- bug#41934: reverse-region no longer works, Richard Copley, 2020/06/20
- bug#41934: reverse-region no longer works, Eli Zaretskii, 2020/06/22
- bug#41934: reverse-region no longer works, Eli Zaretskii, 2020/06/18