[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41936: 28.0.50; AREF: assert that the index is inside bounds
|
From: |
Paul Eggert |
|
Subject: |
bug#41936: 28.0.50; AREF: assert that the index is inside bounds |
|
Date: |
Thu, 18 Jun 2020 14:06:31 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/18/20 1:12 PM, Tino Calancha wrote:
> Is it OK for you to add the following patch?
Yes, good idea. I wondered a while ago (to myself) why AREF doesn't check
subscripts when Emacs is configured with --enable-checking. Now that I think
about it more, it's most likely because AREF was a macro and didn't want to
evaluate its index argument multiple times. We don't need to worry about that
any more.
aref_addr should have a similar check (off by one since one can address one past
the end of an array).
There's no need to change test/manual/etags/c-src/emacs/src/lisp.h as that's
just a data file (and changes can be harmful there as they can mess up the
tests).
I installed the attached.
0001-Check-AREF-and-aref_addr-subscripts.patch
Description: Text Data