[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
|
From: |
Basil L. Contovounesios |
|
Subject: |
bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el |
|
Date: |
Sun, 21 Jun 2020 13:25:31 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Theodor Thornhill <theo@thornhill.no> writes:
> From 4b3f83a4ea36252f7f7552b58529688f6b4c3c9f Mon Sep 17 00:00:00 2001
> From: Theodor Thornhill <theo@thornhill.no>
> Date: Sun, 21 Jun 2020 13:09:42 +0200
> Subject: [PATCH] project.el - eval-when-compile eshell
>
> * lisp/progmodes/project.el: eval-when-compile Eshell so we can use
> 'eshell-buffer-name' in 'project-eshell'
Since eshell-buffer-name is a variable, eval-when-compile is not the
right thing to do here. Instead, there should be a
(defvar eshell-buffer-name) inside project-eshell declaring the symbol
as special. Right?
Thanks,
--
Basil