[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42237: [PATCH] Clean up Tramp version check
From: |
Michael Albinus |
Subject: |
bug#42237: [PATCH] Clean up Tramp version check |
Date: |
Tue, 07 Jul 2020 09:19:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Nicholas Drozd <nicholasdrozd@gmail.com> writes:
Hi Nicholas,
Thanks for working on Tramp.
> I actually saw the "not fit for" error message in the wild. The source
> looked a little strange, so I cleaned it up. This shouldn't change any
> behavior.
Well, this code snippet has its history. Initially, it was (and still
is) used in the Tramp git repository, file aclocal.m4. And that code
snippet is also propagated to trampver.el via template trampver.el.in.
If you want to improve the code, please change only these two files. The
Tramp git repository is located at
<git://git.savannah.gnu.org/tramp.git> (see also the Tramp manual).
> +(ert-deftest tramp-test46-version ()
> + "Check that the version check checks out."
> + (tramp-check-version)
> + (let ((emacs-version "24.3"))
> + (should-error (tramp-check-version)))
> + (let ((tramp-minimum-emacs-version "30.1"))
> + (should-error (tramp-check-version))))
This is a nice extension :-)