[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40704: 28.0.50; Improve and speed up (Gnus) registry saving
From: |
Lars Ingebrigtsen |
Subject: |
bug#40704: 28.0.50; Improve and speed up (Gnus) registry saving |
Date: |
Sun, 19 Jul 2020 17:22:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Presumably there's already code to print a hash table somewhere in
>> Emacs? That would be the other printer, since your patch adds a new
>> one.
>
> That's what the code currently already does. But: See what I wrote
> about the purpose of the patch: our saving code needs to modify how
> elements in the hash table are printed. The Lisp printer doesn't allow
> that per se. My suggested patch substitutes a very inefficient hack
> with a more efficient hack. The current code uses printing + re-reading
> AFAIR - and that on nested hash tables.
>
> I thought long about removing the need for this hack altogehter, but
> this is very complicated, if not impossible (yes, you would need to
> change the printer).
I didn't object to this new, more efficient printer -- I just pointed
out that you should add comments to both of the hash table printers that
there are (now) two of them.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no