bug#42397: [PATCH v2 02/16] ; * lisp/epg.el (epg-signature-to-string): Tiny refactor.

[Jonas Bernoulli]

`concat' treats arguments that are nil as if they were empty strings.
We therefore do not have to write (if TEST THEN "") and can just use
(and TEST THEN).
---
 lisp/epg.el | 32 ++++++++++++++------------------
 1 file changed, 14 insertions(+), 18 deletions(-)

diff --git a/lisp/epg.el b/lisp/epg.el
index 65decf3cf5..e53aa8caaa 100644
--- a/lisp/epg.el
+++ b/lisp/epg.el
@@ -412,24 +412,20 @@ epg-signature-to-string
        (revoked-key "Signature made by revoked key ")
        (no-pubkey "No public key for "))
      key-id
-     (if user-id
-        (concat " "
-                (if (stringp user-id)
-                    (epg--decode-percent-escape-as-utf-8 user-id)
-                  (epg-decode-dn user-id)))
-       "")
-     (if (epg-signature-validity signature)
-        (format " (trust %s)"  (epg-signature-validity signature))
-       "")
-     (if (epg-signature-creation-time signature)
-        (format-time-string " created at %Y-%m-%dT%T%z"
-                            (epg-signature-creation-time signature))
-       "")
-     (if pubkey-algorithm
-        (concat " using "
-                (or (cdr (assq pubkey-algorithm epg-pubkey-algorithm-alist))
-                    (format "(unknown algorithm %d)" pubkey-algorithm)))
-       ""))))
+     (and user-id
+         (concat " "
+                 (if (stringp user-id)
+                     (epg--decode-percent-escape-as-utf-8 user-id)
+                   (epg-decode-dn user-id))))
+     (and (epg-signature-validity signature)
+         (format " (trust %s)"  (epg-signature-validity signature)))
+     (and (epg-signature-creation-time signature)
+         (format-time-string " created at %Y-%m-%dT%T%z"
+                             (epg-signature-creation-time signature)))
+     (and pubkey-algorithm
+         (concat " using "
+                 (or (cdr (assq pubkey-algorithm epg-pubkey-algorithm-alist))
+                     (format "(unknown algorithm %d)" pubkey-algorithm)))))))
 
 (defun epg-verify-result-to-string (verify-result)
   "Convert VERIFY-RESULT to a human readable string."
-- 
2.28.0