[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43218: EWW handles default answer incorrectly when changing a select
From: |
Lars Ingebrigtsen |
Subject: |
bug#43218: EWW handles default answer incorrectly when changing a select |
Date: |
Mon, 07 Sep 2020 00:49:37 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> It probably gets removed as a side effect of
> something else (e.g. of going through `try-completion`) so it probably
> "just" needs more work to actively *preserve* the text-properties.
FOUND IT!!!1!
Man, the completion stuff nests deep...
Anyway, the properties are removed here:
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 864726e3cc..2b188d3e95 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1068,7 +1068,7 @@ completion--replace
;; The properties on `newtext' include things like
;; completions-first-difference, which we don't want to include
;; upon insertion.
- (set-text-properties 0 (length newtext) nil newtext)
+ ;;(set-text-properties 0 (length newtext) nil newtext)
;; Maybe this should be in subr.el.
;; You'd think this is trivial to do, but details matter if you want
;; to keep markers "at the right place" and be robust in the face of
To it sounds like it's just nixing out all the text properties because
it wants to get rid of completions-first-difference and... other things?
If we could identify those other things, then we could remove just them
if minibuffer-allow-text-properties is set.
I've tried looking at what comes out of the machinery with this "patch",
and ... I'm not finding anything much.
Does this sound familiar to anybody? I can grep around to see if
there's any more, I guess...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#43218: EWW handles default answer incorrectly when changing a select, (continued)
- bug#43218: EWW handles default answer incorrectly when changing a select, Lars Ingebrigtsen, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Eli Zaretskii, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Lars Ingebrigtsen, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Nicolas Graner, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Lars Ingebrigtsen, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Drew Adams, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Lars Ingebrigtsen, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Drew Adams, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Lars Ingebrigtsen, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Stefan Monnier, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select,
Lars Ingebrigtsen <=
- bug#43218: EWW handles default answer incorrectly when changing a select, Lars Ingebrigtsen, 2020/09/06
- bug#43218: EWW handles default answer incorrectly when changing a select, Drew Adams, 2020/09/06