[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from wind
From: |
Lars Ingebrigtsen |
Subject: |
bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from window-configuration-change-hook |
Date: |
Mon, 07 Sep 2020 19:07:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Pip Cet <pipcet@gmail.com> writes:
> * keyboard.c (timer_check): Call `block_input' and turn off
> atimers around the creation of the temporary timer list copy.
>
> * fns.c (concat): Don't assume argument size remains unchanged
> after call to `Fmake_list'. Return incorrect results (but don't
> segfault) in that case.
Skimming this thread, it seemed like the first part fixes a segfault
(and the second part was probably not needed), but not even the first
part was applied? (I just had a peek at timer_check to check.)
The discussion instead turned to the idea of avoiding the
timers = Fcopy_sequence (Vtimer_list);
completely, and just working directly off of Vtimer_list. Which seems
like a good idea, but there may be unknown unknowns in that scenario?
In any case, the timer_check change seems safe, and fixes a (somewhat
obscure) segfault, so does anybody object to putting that in? (We can
also add a FIXME to the code here mentioning the possibility of not
copying the list.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from window-configuration-change-hook,
Lars Ingebrigtsen <=