[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsi
From: |
Juri Linkov |
Subject: |
bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy) |
Date: |
Mon, 07 Sep 2020 21:46:11 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
> The next step here is probably to fix the cases where there's a default,
> but where the prompt doesn't mention them. Like:
Are you sure about this change in 1921d2176b?
diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index d8f932e7a4..56c936e773 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -1028,7 +1028,7 @@ tab-bar-rename-tab
(tab-index (or current-prefix-arg (1+ (tab-bar--current-tab-index
tabs))))
(tab-name (alist-get 'name (nth (1- tab-index) tabs))))
(list (read-from-minibuffer
- "New name for tab (leave blank for automatic naming): "
+ (format-prompt "New name for tab" tab-name)
nil nil nil nil tab-name)
current-prefix-arg)))
(let* ((tabs (funcall tab-bar-tabs-function))
@@ -1057,7 +1057,7 @@ tab-bar-rename-tab-by-name
(alist-get 'name tab))
(funcall tab-bar-tabs-function)))))
(list tab-name (read-from-minibuffer
- "New name for tab (leave blank for automatic naming): "
+ (format-prompt "New name for tab" tab-name)
nil nil nil nil tab-name))))
(tab-bar-rename-tab new-name (1+ (tab-bar--tab-index-by-name tab-name))))
I'm not the author of this code, so I don't know how it should work,
but the old prompt with text "leave blank for automatic naming"
makes sense to me.
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), (continued)
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/06
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/06
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Drew Adams, 2020/09/06
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Michael Heerdegen, 2020/09/06
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/06
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/06
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Michael Heerdegen, 2020/09/06
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/06
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Michael Heerdegen, 2020/09/06
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/06
bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy),
Juri Linkov <=
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/07
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Juri Linkov, 2020/09/08
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/08
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Juri Linkov, 2020/09/09
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/10
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Andrii Kolomoiets, 2020/09/11
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/11
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Andrii Kolomoiets, 2020/09/14
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/09/14
bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Juri Linkov, 2020/09/12