[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43314: vc-bzr-test-bug9726 test fails on master
From: |
Glenn Morris |
Subject: |
bug#43314: vc-bzr-test-bug9726 test fails on master |
Date: |
Sat, 12 Sep 2020 12:53:46 -0400 |
User-agent: |
Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) |
Version: 27.2
commit 184a497 (HEAD, origin/emacs-27, emacs-27)
Date: Sat Sep 12 09:51:32 2020 -0700
Make vc-bzr tests work with brz 3.1 (bug#43314)
* test/lisp/vc/vc-bzr-tests.el (vc-bzr-test-bug9726)
(vc-bzr-test-bug9781, vc-bzr-test-faulty-bzr-autoloads):
Make them work with brz 3.1.
diff --git a/test/lisp/vc/vc-bzr-tests.el b/test/lisp/vc/vc-bzr-tests.el
index f738da7..b68a694 100644
--- a/test/lisp/vc/vc-bzr-tests.el
+++ b/test/lisp/vc/vc-bzr-tests.el
@@ -38,13 +38,26 @@
;; abort if they cannot. I could not figure out how to stop bzr
;; doing that, so just give it a temporary homedir for the duration.
;; http://bugs.launchpad.net/bzr/+bug/137407 ?
+ ;;
+ ;; Note that with bzr 2.x, this works:
+ ;; mkdir /tmp/bzr
+ ;; HOME=/nonexistent BZR_HOME=/tmp/bzr bzr status
+ ;; but with brz 3.1, it complains:
+ ;; "failed to open trace file: [Errno 13] Permission denied: '/nonexistent'"
+ ;; which confuses vc-dir.
+ ;; We can quieten brz by adding either BRZ_LOG=/dev/null, or
+ ;; XDG_CACHE_HOME=/tmp/bzr (log defaults to XDG_CACHE_HOME/breezy/brz.log),
+ ;; but it seems simpler to just set HOME to a newly created
+ ;; temporary directory.
+ ;; TODO does this means tests should be setting XDG_ variables (not
+ ;; just HOME) to temporary values too?
(let* ((homedir (make-temp-file "vc-bzr-test" t))
(bzrdir (expand-file-name "bzr" homedir))
(ignored-dir (progn
(make-directory bzrdir)
(expand-file-name "ignored-dir" bzrdir)))
(default-directory (file-name-as-directory bzrdir))
- (process-environment (cons (format "BZR_HOME=%s" homedir)
+ (process-environment (cons (format "HOME=%s" homedir)
process-environment)))
(unwind-protect
(progn
@@ -81,7 +94,7 @@
(expand-file-name "subdir" bzrdir)))
(file (expand-file-name "file" bzrdir))
(default-directory (file-name-as-directory bzrdir))
- (process-environment (cons (format "BZR_HOME=%s" homedir)
+ (process-environment (cons (format "HOME=%s" homedir)
process-environment)))
(unwind-protect
(progn
@@ -119,7 +132,7 @@
(expand-file-name "foo.el" bzrdir)))
(default-directory (file-name-as-directory bzrdir))
(generated-autoload-file (expand-file-name "loaddefs.el" bzrdir))
- (process-environment (cons (format "BZR_HOME=%s" homedir)
+ (process-environment (cons (format "HOME=%s" homedir)
process-environment)))
(unwind-protect
(progn
- bug#43314: vc-bzr-test-bug9726 test fails on master, (continued)
- bug#43314: vc-bzr-test-bug9726 test fails on master, Stefan Kangas, 2020/09/10
- bug#43314: vc-bzr-test-bug9726 test fails on master, Eli Zaretskii, 2020/09/11
- bug#43314: vc-bzr-test-bug9726 test fails on master, Lars Ingebrigtsen, 2020/09/11
- bug#43314: vc-bzr-test-bug9726 test fails on master, Eli Zaretskii, 2020/09/11
- bug#43314: vc-bzr-test-bug9726 test fails on master, Lars Ingebrigtsen, 2020/09/11
- bug#43314: vc-bzr-test-bug9726 test fails on master, Eli Zaretskii, 2020/09/11
bug#43314: vc-bzr-test-bug9726 test fails on master,
Glenn Morris <=
- bug#43314: vc-bzr-test-bug9726 test fails on master, Stefan Kangas, 2020/09/13
- bug#43314: vc-bzr-test-bug9726 test fails on master, Lars Ingebrigtsen, 2020/09/13
- bug#43314: vc-bzr-test-bug9726 test fails on master, Stefan Kangas, 2020/09/13
- bug#43314: vc-bzr-test-bug9726 test fails on master, Lars Ingebrigtsen, 2020/09/13
- bug#43314: vc-bzr-test-bug9726 test fails on master, Stefan Kangas, 2020/09/13
- bug#43314: vc-bzr-test-bug9726 test fails on master, Lars Ingebrigtsen, 2020/09/13