[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43329: 28.0.50; Incorrect indentation for variables starting with `d
From: |
Lars Ingebrigtsen |
Subject: |
bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form |
Date: |
Sun, 13 Sep 2020 14:44:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Would something as simple as the following (which fixes this use case)
>> be the correct fix? It only indents these forms as macros if they are
>> top-level...
>
> It obviously has the downside of not indenting properly those
> definitions which are not at the very-top level. E.g. definitions
> inside an `eval-when-compile` or other.
That's true. I guess the (def* calls can happen at any level, really.
But the (def* thing is a heuristic, and we could say that we only use
that heuristic at the top level?
We should then mark all the (def* things we have in-tree with explicit
indentation marking (which I think we should do anyway, really).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no