[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43308: 28.0.50; Improvements to Edit->Search menu
From: |
Juri Linkov |
Subject: |
bug#43308: 28.0.50; Improvements to Edit->Search menu |
Date: |
Tue, 22 Sep 2020 21:10:13 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
>> >> Why no keybindings are shown for nonincremental menu items?
>> >> They still have keybindings, e.g. nonincremental forward search
>> >> can be started with 'C-s RET', nonincremental backward search
>> >> with 'C-r RET', nonincremental regexp search 'C-M-s RET', etc.
>> >
>> > I suppose I could add some explicitly, with :keys.
>> > That makes sense. Unfortunately, none show up
>> > automatically. It would be good to somehow fix that.
>>
>> How about the following patch?
>
> But the keys this will show don't invoke the same commands, they
> invoke slightly different commands, don't they? I don't think we ever
> show keys that invoke a different command, why do this here?
The comment in 'nonincremental-search-forward' says:
;; Ideally, this whole command would be equivalent to `C-s RET'.
This seems to imply that currently it's not equivalent.
Then indeed displaying wrong keys would be misleading.
>> Another problem is that selecting "Continue Tags Search"
>> signals the error:
>>
>> emacs -Q
>> Select "Edit" -> "Search" -> "Continue Tags Search"
>>
>> Lisp error: (wrong-type-argument commandp fileloop-continue)
>
> I guess this is a leftover from migration to Xref.
Do you mean these obsolete menu items should be removed since
now there are Xref commands in the "Go To" submenu?
- bug#43308: 28.0.50; Improvements to Edit->Search menu, (continued)
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Ihor Radchenko, 2020/09/20
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Eli Zaretskii, 2020/09/20
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/20
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Juri Linkov, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Andreas Schwab, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Juri Linkov, 2020/09/22
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Eli Zaretskii, 2020/09/22
- bug#43308: 28.0.50; Improvements to Edit->Search menu,
Juri Linkov <=
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Eli Zaretskii, 2020/09/22
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/22
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Juri Linkov, 2020/09/22
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Drew Adams, 2020/09/22
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Eli Zaretskii, 2020/09/26
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Drew Adams, 2020/09/26
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Eli Zaretskii, 2020/09/26
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Drew Adams, 2020/09/26
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Eli Zaretskii, 2020/09/26
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Lars Ingebrigtsen, 2020/09/26