bug#43252: 27.1; DBus properties lack type hints or overrides

[Hugh Daschbach]

Michael Albinus writes:

> Hugh Daschbach <hugh@ccss.com> writes:
>
> Hi Hugh,
>
> Oops, I'm mistaken here. The directory shall be called 
> dbus-resources,
> see .../test/file-organization.org. Sorry.

No worries.  Done.

> I'd vote for the latter, with the first argument :session 
> preceding
> the other arguments in the same line. Like
>
> (let* ((property
>         (dbus-introspect-get-property
>          :session dbus--test-service
>          dbus--test-path interface property-name)))
>    ...)

I think I've addressed this.  I reformatted a few tests that were
similarly indented.

> If you have one comment for several functions, use only one 
> parenthesis
> per line like
>
> (dbus--test-run-property-test, dbus--test-property)
> (dbus-test06-property-types): Test property registration, set, 
> get.

Done.  I think.


> `dbus-register-property' (if SELECTOR is `register') or

Done.  Apologies for not picking up the quoting issue the first 
time you
mentioned it.

> I bet the dot "." has the font-lock-warning-face (red foreground 
> color)
> in your buffer. Admittedly, it doesn't look prominent :-(
>
> Move the cursor over the misplaced dot; there shall be a help 
> message about.

Done.

> I don't believe we need this message. We see that we're done :-)

Gone.

> > * lisp/net/dbus.el (new defconst): D-Bus deprecation name.
> >
> > * test/lisp/net/dbus-tests.el  (dbus--tests-dir)
> > (dbus--test-introspect) (dbus--test-examine-interface)
> > (dbus--test-validate-annotations) 
> > (dbus--test-validate-property)
> > (dbus--test-validate-m-or-s) (dbus--test-validate-signal)
> > (dbus--test-validate-method) (dbus-test07-introspection): new 
> > tests.

I think I understand the ChangeLog format.  Additional corrections
welcome.

> The docstring line does not fit 80 chars. What about
>
> "An annotation indicating a deprecated interface, method, 
> signal, or property."

Done.

> > +(ert-deftest dbus-test07-introspection ()
> > +  :tags '(:expensive-test)
> > +  "Register an Introspection interface then query it."
>
> :tags must be after the docstring.

Corrected.

> > Cheers,
> > Hugh
>
> Best regards, Michael.

I think I've addressed all the issues you pointed out.  Let me 
know if
there's something that still doesn't look right.

Thanks
Hugh

0001-Add-D-Bus-property-tests.patch
Description: Property tests.

0002-Add-D-Bus-Introspection-tests.patch
Description: Introspection tests.