[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30990: Should the byte compiler warn about :type mismatches?
From: |
Lars Ingebrigtsen |
Subject: |
bug#30990: Should the byte compiler warn about :type mismatches? |
Date: |
Fri, 25 Sep 2020 15:18:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Robert Pluim <rpluim@gmail.com> writes:
> Except that the underlying type is '(repeat ....) so I wonder if this:
>
> (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet)
> (unless wallet
> (setq w (locate-user-emacs-file (concat "sql-wallet" ext)
> (concat ".sql-wallet" ext)))
> (when (file-exists-p w)
> (setq wallet w))))) ; <= this returns a string
>
> should use (setq wallet (list w)) instead
I went ahead and fixed this along with a bunch of other warnings
revealed by the test (that has snuck in after Rober fixed the last batch,
I think).
There's some that are rather intractable, though, like
sql-postgres-login-params.
These remain:
whitespace-indentation-regexp
whitespace-space-after-tab-regexp
sql-postgres-login-params
gdb-display-source-buffer-action
I don't quite understand what's wrong here:
(defcustom whitespace-indentation-regexp
'("^\t*\\(\\( \\{%d\\}\\)+\\)[^\n\t]"
. "^ *\\(\t+\\)[^\n]")
[...]
:type '(cons (regexp :tag "Indentation SPACEs")
(regexp :tag "Indentation TABs"))
:group 'whitespace)
Isn't that how you specify a cons of two values?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no