[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20971: 24.4; occur-1 makes my buffer read-only
From: |
Lars Ingebrigtsen |
Subject: |
bug#20971: 24.4; occur-1 makes my buffer read-only |
Date: |
Fri, 25 Sep 2020 16:04:37 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Kangas <stefan@marxist.se> writes:
> I think *Occur* should definitely be read-only, so your first patch is
> the wrong solution in my opinion.
>
> On the other hand, I see no drawbacks with wrapping the relevant calls
> in:
>
> (with-current-buffer occur-buf
> ...)
>
> At the very least, that would make the intention of that code a bit more
> clear.
>
> But that entire part of the code is already wrapped in
> (with-current-buffer occur-buf ...). So why are we not in occur-buf
> already?
I am guessing the reporter had some misbehaving code running off of
`display-buffer' that changed the current buffer:
(display-buffer occur-buf)
(when occur--final-pos
(set-window-point
(get-buffer-window occur-buf 'all-frames)
occur--final-pos))
(setq next-error-last-buffer occur-buf)
(setq buffer-read-only t)
(set-buffer-modified-p nil)
(run-hooks 'occur-hook)))))))
So everything after displaying the buffer runs somewhere else. We could
defensively re-wrap the rest in a with-current-buffer, but... I think
the bug is in the code that changed the current buffer, really.
So I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#20971: 24.4; occur-1 makes my buffer read-only,
Lars Ingebrigtsen <=