bug#43612: 28.0.50; Unable to dehighlight region in Customize

[Lars Ingebrigtsen]

Mauro Aranda <maurooaranda@gmail.com> writes:

> Click somewhere else in the buffer.  Observe that Emacs highlights the
> new region.  Before, a mouse-1 event would dehighlight it and just set
> point where the click happened.
>
> This started happening after the refactor in widget-button-click in
> 8b61e20e4edb9d2f67134bc9f3739f936aafb01c
>
> The reason is that the condition for the when form is evaluating to nil,
> skipping all the dispatch of the click when not inside a widget button.
> That is, (widget-get button :button-overlay) returns nil here.  I don't
> understand why that extra check was added, but this behavior seems
> undesirable to me.

Yup; I've now removed that check.

I'm not quite sure what it was trying to fix...  Bad commit message.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no