[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41250: 28.0.50; Dired displays unconditionally ls-switches on modeli
From: |
Juri Linkov |
Subject: |
bug#41250: 28.0.50; Dired displays unconditionally ls-switches on modeline |
Date: |
Wed, 30 Sep 2020 22:04:51 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
> Drew Adams <drew.adams@oracle.com> writes:
>
>> Sorry. `diredp' should be `dired' everywhere.
>> This patch takes care of that typo.
>
> Looks good to me, so I've now applied your patch to Emacs 28.
>
> Some bikeshedding ensued, and people should feel free to alter the code
> (as-is vs t, for instance).
I recall I asked for 't' instead of 'as-is', but actually 'as-is' is fine
as a value as long as it is not checked for this value in function body.
And indeed it's on the 't' branch of 'cond'.
> And I'm not sure about this:
>
> + (concat " " xs (and (< l2 l1) "…")))))
>
> Perhaps that should be conditional upon the terminal being able to
> display that character?
Like everywhere else (if (char-displayable-p ?…) "…" "...")
bug#41250: 28.0.50; Dired displays unconditionally ls-switches on modeline, Drew Adams, 2020/09/30