[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43725: 28.0.50; Include feature/native-comp into master
From: |
Lars Ingebrigtsen |
Subject: |
bug#43725: 28.0.50; Include feature/native-comp into master |
Date: |
Thu, 01 Oct 2020 03:34:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Andrea Corallo <akrl@sdf.org> writes:
>> Was the patch against the trunk supposed to be included here?
>
> Hi Lars, no it wasn't :)
>
> In the sense that I'm not sure how do we prefer to proceed with the
> review and I'm open for inputs on that.
Right. :-)
> I didn't know if every time I update the branch is worth posting here a
> 10K+ LOC patch, so I waited. Also assuming the review will take some
> time to go through I'm not really sure how this is practical.
>
> OTOH as the branch is already in emacs.git should be trivial for
> reviewers at any point in time to produce the diff and quote the parts
> they like to discuss.
Sure, that's fine. That would be
git diff origin/feature/native-comp..origin/master
?
> Slightly different but related: I wanted to mention that I think would
> be really good if possible to retain the current history. That is going
> for a merge instead of applying a single patch. I believe this would be
> of great help for me to maintain the code in the future.
Sure, sounds good.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no