bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone han


From: Ulf Jasper
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Date: Thu, 01 Oct 2020 18:19:29 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)

Am 01.10.2020 um 16:38 (+0300) schrieb Thomas Plass:

> But I'd rather let Ulf have the final say about the patches and how
> the data is to be tested.

I agree with Lars here. (Thank you, Lars, for your investigation!)

When patching icalendar.el (or any other file) one must make sure that
the corresponding unit tests do not fail.  If necessary the unit tests
need to be adjusted.  If possible one should add unit tests so that all
code changes get covered.  (And so on -- the usual ideas behind unit
tests.)

It looks like your patch of 'icalendar-tests.el' does not contain
the samples from the ics files.  Could you please add these?







reply via email to

[Prev in Thread] Current Thread [Next in Thread]