[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outli
From: |
Lars Ingebrigtsen |
Subject: |
bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline |
Date: |
Sat, 17 Oct 2020 08:36:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Yuan Fu <casouri@gmail.com> writes:
> This patch should make outline behaves like org: S-TAB always cycle
> the whole buffer, regardless where is the point. TAB cycles a heading,
> and does nothing if point is before the first heading.
I think the behaviour makes sense, but the implementation isn't ideal:
[...]
> + (condition-case nil
> + (pcase (outline--cycle-state)
> + ('hide-all
> + (if (outline-has-subheading-p)
> + (progn (outline-show-children)
> + (message "Only headings"))
> + (outline-show-subtree)
> + (message "Show all")))
> + ('headings-only
> + (outline-show-subtree)
> + (message "Show all"))
> + ('show-all
> + (outline-hide-subtree)
> + (message "Hide all")))
> + ;; If error: "Before first heading" occurs, ignore it.
> + (error nil)))
This is basically an `ignore-errors' around a whole bunch of code, used
as a program flow mechanism, and that's always awkward, because it hides
real errors in the code.
Altering the functions to not error out in these situations would be
better.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, (continued)
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Yuan Fu, 2020/10/13
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Juri Linkov, 2020/10/14
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Lars Ingebrigtsen, 2020/10/15
- bug#41198: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Yuan Fu, 2020/10/15
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Juri Linkov, 2020/10/16
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Yuan Fu, 2020/10/16
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline,
Lars Ingebrigtsen <=
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Juri Linkov, 2020/10/17
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Yuan Fu, 2020/10/17
- bug#41198: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Lars Ingebrigtsen, 2020/10/18
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Yuan Fu, 2020/10/18
- bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline, Lars Ingebrigtsen, 2020/10/19