bug#44068: 28.0.50; Faulty uses of tabulated-list-format

[Stephen Berman]

On trying out the new tabulated-list implementation of the bookmarks
list I noticed that, when clicking on the File header, the sort
indicator is not displayed, unlike with the Bookmark header.  Then I
noticed that the same thing happens in the tabulated buffer list (C-x
C-b).  Then I grepped for all uses of tabulated-list-format in the Emacs
sources and found the same problem in most of them.  The reason is that
in these modes the width of at least one of the columns is too narrow,
so that tabulated-list-init-header omits the indicator.  In most cases
the problematic column is the final one, but in a couple of cases there
are also non-final too narrow columns.  And I think these bugs are due
to a misleading description in tabulated-list-format's doc string.  The
attached patch corrects the doc string and the problematic uses of
tabulated-list-format.  The patch also fixes a typo and tries to improve
column alignment in timer-list-mode: this is one of the few modes
derived from tabulated-list-mode whose column widths didn't need to be
corrected, but the alignment seemed suboptimal; however, when the header
line uses a variable-pitch face, the alignment is still suboptimal even
with the patch, and I don't know how to fix that.

In GNU Emacs 28.0.50 (build 34, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, 
cairo version 1.17.3)
 of 2020-10-18 built on strobe-jhalfs
Repository revision: b7dfae3a8168977013e8de1df0916c51e76e7326
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Linux From Scratch SVN-20200401


2020-10-18  Stephen Berman  <stephen.berman@gmx.net>

        Fix uses of tabulated-list-format

        * lisp/emacs-lisp/tabulated-list.el (tabulated-list-format):
        Correct the documentation of the WIDTH element.

        * lisp/bookmark.el (bookmark-bmenu-mode):
        * lisp/buff-menu.el (list-buffers--refresh):
        * lisp/emacs-lisp/package.el (package-menu-mode)
        (package-archive-column-width):
        * lisp/misc.el (list-dynamic-libraries--refresh):
        * lisp/org/org-lint.el (org-lint--report-mode):
        * lisp/progmodes/flymake.el (flymake-diagnostics-buffer-mode):
        * lisp/simple.el (process-menu-mode): Increase column width in
        order to display sort indicator.

        * lisp/emacs-lisp/timer-list.el (timer-list-mode): Improve column
        alignment.
        (timer-list--function-predicate): Correct typo in doc string.

txt3JRlVvlOzk.txt
Description: Fix uses of tabulated-list-format