bug#44173: 28.0.50; gdb-mi mangles strings with octal escapes

[Mattias Engdegård]

23 okt. 2020 kl. 20.20 skrev Eli Zaretskii <eliz@gnu.org>:

> I don't understand your answers and don't see how they
> resolve the issues I raised.

Sorry if I've been communicating badly (but it takes two to do it).
I honestly thought I did address your concerns but must have misunderstood you.
Please tell me what you believe I have not explained properly, and I promise 
I'll do my best to answer it without referring to any previous message.

Meanwhile, here is a proof of concept which may clarify what I failed to put in 
words. It actually runs both the old and new value parsers on data sent by GDB, 
and logs an error message if discrepancies are found. They seem to work 
identically unless there are strings with octal escapes, which are handled 
correctly by the new parser. (Of course, a proper patch would not retain the 
old parser.)

If gdb-mi-decode-strings is non-nil, then file names, string contents etc are 
properly decoded as UTF-8 as expected, without any of the bugginess of the 
current code. Otherwise raw bytes are shown as octal escapes, which also fixes 
the original bug.

gdb-mi.diff
Description: Binary data