bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#44294: No widen by xref-find-definitions


From: Dmitry Gutov
Subject: bug#44294: No widen by xref-find-definitions
Date: Thu, 29 Oct 2020 13:31:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 28.10.2020 22:01, Juri Linkov wrote:
-         (user-error "Rerun etags: `%s' not found in %s"
-                      pat buffer-file-name)))
+         (if (or (= (point-min) 1) (not widen-automatically))
+              (user-error "Rerun etags: `%s' not found in %s"
+                          pat buffer-file-name)
+            ;; Rerun after removing narrowing
+            (widen)
+            (etags-goto-tag-location tag-info))))

By the way... have you tried to use the same method here as in elisp-mode? Meaning, widen unconditionally inside 'save-restriction'.

There should be no reason for backends to do it differently. And this way, you don't have to always search twice for a missing tag when inside a narrowing.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]