bug#43609: 28.0.50; eldoc-documentation-function [vs new eldoc-display-functions]

[João Távora]

João Távora <joaotavora@gmail.com> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> João Távora <joaotavora@gmail.com> writes:
>>
>>> [Lars, I'm CC'ing you specifcally since there's a patch to review at the
>>> end.]
>>
>> I don't really know much about eldoc, so I don't have much to say here...
>>
>> [...]
>>
>>> +(defalias 'elisp-eldoc-documentation-function 
>>> 'elisp--documentation-one-liner
>>
>> [...]
>>
>>> +(make-obsolete 'elisp-eldoc-documentation-function
>>> +               "use ElDoc's interfaces instead." "28.1")
>>> +
>>
>> But this seems like the correct approach -- we should never remove
>> non-internal functions without going through the obsoletion process.
>> (And "--" functions are the only ones that are clearly marked as
>> internal; for internalish functions prior to that convention we have to
>> do this for all of them, whether we consider them internal or not.)
>
> OK, I'm pushing that.

I just did this.  elisp-eldoc-documentation-function is now in master
again.  Martin, from what I understand of this bug, fixing your problem
is now this short snippet away in your .emacs or in your
martin-tooltip.el library:

   (add-hook 'emacs-lisp-mode-hook
      (lambda () (setq-local eldoc-documentation-function
                             #'elisp-eldoc-documentation-function)))

The byte-compiler should warn you that
elisp-eldoc-documentation-function is obsoleted, but that's fine.

I'm also closing this bug, I will of course re-open if you don't agree.

João