Mauro Aranda <
maurooaranda@gmail.com> writes:
> Eli Zaretskii <
eliz@gnu.org> writes:
>
>>> From: Mauro Aranda <
maurooaranda@gmail.com>
>>> Date: Fri, 30 Oct 2020 11:03:39 -0300
>>> Cc: Drew Adams <
drew.adams@oracle.com>,
14635@debbugs.gnu.org>>>
>>> > Doesn't customizing a face record the original value in some property
>>> > of the face symbol? If so, reverting the customizations should use
>>> > those recorded values, I think.
>>>
>>> AFAICT, it doesn't right now. I followed the recipe I gave, and then:
>>> (symbol-plist 'default)
>>> The relevant properties I see are:
>>> * face-defface-spec ==> ((t nil))
>>> which won't take us anywhere.
>>> * theme-face, which has the customized value for the user theme, and
>>> * customized-face, which again, has the customized value.
>>>
>>> But I see no immediate reason why we shouldn't start doing it, if you
>>> think it is OK to use that to solve this issue. My only questions are
>>> if it would be best to do it in Customize or in faces.el, and if we
>>> should only special case the default face.
>>
>> I'd begin with doing this in Customize, since it is the only user of
>> this property.
>
> I'll try to do it. Thank you.
I attach a patch that makes Customize store the original value of the
default face if the user ever changes it, and then uses it when
reverting.
Basically, Customize tell faces.el the exactly spec to set, by putting a
fake entry under the user theme (and later removing it).
0001-Fix-reverting-the-default-face-to-standard-themed-st.patch