bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#45879: 28.0.50; [PATCH] missing defvar for keymap-name-history


From: Lars Ingebrigtsen
Subject: bug#45879: 28.0.50; [PATCH] missing defvar for keymap-name-history
Date: Tue, 19 Jan 2021 07:09:02 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

"James N. V. Cash" <james.nvc@gmail.com> writes:

> It seems that the new describe-keymaps function in help-fns.el is
> missing a defvar for keymap-name-history. This results in an error
> when using, e.g. Helm as the completing-read function.
>
> The attached patch adds the defvar to help-fns.el.

Thanks; applied to Emacs 28.

As Drew pointed out, `completing-read' helpfully defines variables if
they aren't already, but I think we should define them, because not
doing so leads to the problems we see in Helm, for instance.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]