[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41412: 27.0.90; Value of default directory in completions buffer
From: |
Lars Ingebrigtsen |
Subject: |
bug#41412: 27.0.90; Value of default directory in completions buffer |
Date: |
Sat, 23 Jan 2021 19:47:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I think that sounds likely. The patch that introduced this code is
>> below, and it indeed changes the `file-name-directory' to
>> `file-name-as-directory' (among other things).
>
> But it also changed a fair bit around it. And the `substring` is quite
> different.
> When I look at the history of this code,
> 30c7e54299fc81cd3122a17ef130ab69e9855f99 looks wrong. In order not to
> change the behavior, I suspect it should have been:
>
> (buffer-substring (minibuffer-prompt-end)
> (+ (minibuffer-prompt-end) (or completion-base-size
> 0))))))))
>
> and then 326fdb9ec05ab5e4aec0c7064272bb3d223e9875 looks wrong again
> since it presumes that `completion-base-size` is nil whereas it usually
> isn't/wasn't when completing files.
Aha. But then what would the correct fix now? I haven't tried the
proposed change (i.e., just change to `file-name-directory'), but it
sounds logical to me. That is, if the user has typed "~/foo/bar/zo"
then use "~/foo/bar" as the default directory.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no