bug#45617: <query-replace> loses the edit region. Works in 23.3, broke in 26.3

[Bob Floyd]

I added query-replace-read-argsX to my .emacs file and changed the caller.
Several trys and it appears to be working!

*Messages*:

Mark set
region: 6336 6582
Mark set
Replaced 3 occurrences
Mark set
region: 6337 6582
Mark set
Replaced 3 occurrences
Mark set
region: 6343 6582
Mark set
Replaced 3 occurrences
Mark set
region: 6336 6582
Mark set
Replaced 3 occurrences

So it looks to me like the problem has something to do with 'c:/Program
Files/Emacs-26.3/share/emacs/26.3/lisp/replace.elc' not being loaded, even
when I run '"C:\Program Files\Emacs-26.3\bin\runemacs.exe" -Q'.

Correct?

-----Original Message-----
From: Juri Linkov [mailto:juri@linkov.net] 
Sent: Thursday, January 28, 2021 10:42 AM
To: Bob Floyd
Cc: 'Eli Zaretskii'; 45617@debbugs.gnu.org
Subject: Re: bug#45617: <query-replace> loses the edit region. Works in
23.3, broke in 26.3

> Good idea. I placed this query-replaceX in my .emacs:

Thanks.

> Here is the *Messages* buffer beginning with the (1) select region:
>
> Mark set
> region: 6576 6582

This means that the fixed function query-replace-read-args
is not loaded.

> Mark set
> Replaced 1 occurrence
> Auto-saving...done
> Mark set
>
> What would you like me to do next?

I'd recommend you to place the fixed function query-replace-read-args
in your .emacs the same way as you placed query-replaceX.

If you want, you can rename it, then the caller should be renamed as well.
Or you could try to place it in .emacs without renaming:

(defun query-replace-read-args (prompt regexp-flag &optional noerror)
  (unless noerror
    (barf-if-buffer-read-only))
  (save-mark-and-excursion
    (let* ((from (query-replace-read-from prompt regexp-flag))
           (to (if (consp from) (prog1 (cdr from) (setq from (car from)))
                 (query-replace-read-to from prompt regexp-flag))))
      (list from to
            (or (and current-prefix-arg (not (eq current-prefix-arg '-)))
                (and (plist-member (text-properties-at 0 from)
'isearch-regexp-function)
                     (get-text-property 0 'isearch-regexp-function from)))
            (and current-prefix-arg (eq current-prefix-arg '-))))))