[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46119: 28.0.50; this-error-recenter
From: |
Tino Calancha |
Subject: |
bug#46119: 28.0.50; this-error-recenter |
Date: |
Sat, 30 Jan 2021 16:01:40 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Juri Linkov <juri@jurta.org> writes:
>> +(defun this-error-recenter (&optional arg)
>> + "Recenter the current displayed error in the `next-error' buffer."
>> + (interactive "P")
>> + (if (not (or (eq major-mode 'occur-mode)
>> + (derived-mode-p 'compilation-mode)))
>> + (user-error "This command is for *Occur* or *Grep* buffers")
>> + (funcall next-error-function 0 nil)
>> + (recenter-top-bottom arg)
>> + (pop-to-buffer next-error-last-buffer)))
>
> I wonder why restrict this only to occur and compilation?
I think because I was blindly looking only to my particular use case:
Occur/Grep.
> Like C-M-v/C-M-S-v and M-PgUp/M-PgDown can scroll up/down other window
> in any mode, you can use such code to recenter other window everywhere:
>
> (with-selected-window (other-window-for-scrolling) (recenter-top-bottom))
Yeah, it makes sense. The only thing is that it makes harder to find
the right name for this command; I think by improving the docstring
makes more clear what is this about.
How does it look now?:
(defun this-error-recenter (&optional arg)
"Recenter the current displayed error in the `next-error' buffer.
If called not from a `next-error' buffer, then it just calls
`recenter-top-bottom' in the other window."
(interactive "P")
(if (not (or (eq major-mode 'occur-mode) (derived-mode-p 'compilation-mode)))
(with-selected-window (other-window-for-scrolling) (recenter-top-bottom
arg))
(funcall next-error-function 0 nil)
(recenter-top-bottom arg)
(pop-to-buffer next-error-last-buffer)))
- bug#46119: 28.0.50; this-error-recenter, Tino Calancha, 2021/01/26
- bug#46119: 28.0.50; this-error-recenter, Juri Linkov, 2021/01/27
- bug#46119: 28.0.50; this-error-recenter,
Tino Calancha <=
- bug#46119: 28.0.50; this-error-recenter, Juri Linkov, 2021/01/30
- bug#46119: 28.0.50; this-error-recenter, Tino Calancha, 2021/01/30
- bug#46119: 28.0.50; this-error-recenter, Juri Linkov, 2021/01/31
- bug#46119: 28.0.50; this-error-recenter, Tino Calancha, 2021/01/31
- bug#46119: 28.0.50; this-error-recenter, Juri Linkov, 2021/01/31
bug#46119: 28.0.50; this-error-recenter, Richard Stallman, 2021/01/28