[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
From: |
Robert Pluim |
Subject: |
bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header? |
Date: |
Fri, 12 Feb 2021 10:55:05 +0100 |
>>>>> On Fri, 12 Feb 2021 08:54:13 +0200, Protesilaos Stavrou
>>>>> <info@protesilaos.com> said:
Protesilaos> Dear maintainers,
Protesilaos> In vc-git.el the header for vc-dir stashes is propertized with
its own
Protesilaos> keymap. This means that while point is over the value of the
"Stash:"
Protesilaos> header, the specified keymap comes into effect, instead of the
main one
Protesilaos> for vc-dir. The latter takes effect when point is anywhere
but that
Protesilaos> header's value.
Protesilaos> Should this principle be applied to the value of the "Branch"
header as
Protesilaos> well? The attached patch is a proof-of-concept to that end.
Protesilaos> If you believe this is worth doing, what else do you think
should go
Protesilaos> into such a patch from a usability standpoint?
Looks good to me, although Iʼve just noticed the vc and vc-dir have
confusingly different bindings for vc-retrieve-tag and vc-create-tag
Maybe put vc-create-tag on C-x v c as well?
Robert