bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#46574: cperl-mode: Improve detection of entries for imenu [PATCH]


From: Lars Ingebrigtsen
Subject: bug#46574: cperl-mode: Improve detection of entries for imenu [PATCH]
Date: Wed, 17 Feb 2021 00:03:12 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

haj@posteo.de (Harald Jörg) writes:

> This patch helps CPerl mode to detect various declarations which should
> go into the imenu index but were missed, and also prevents some false
> positives from being included.  Undetected package declarations also led
> to wrong namespace attributions for subroutines declared within those
> packages.

I've only skimmed the patch, but it makes sense to me.  When applying
it, though, patch said:

patching file lisp/progmodes/cperl-mode.el
Hunk #2 succeeded at 1210 (offset -41 lines).
Hunk #3 succeeded at 1367 (offset -41 lines).
Hunk #4 succeeded at 5286 (offset -41 lines).
Hunk #5 succeeded at 5368 (offset -41 lines).
Hunk #6 succeeded at 5403 (offset -41 lines).
Hunk #7 succeeded at 6734 (offset -41 lines).

Which is odd.  Could you check whether the patch is against the current
Emacs trunk?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]