bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43725: 28.0.50; Include feature/native-comp into master


From: Andrea Corallo
Subject: bug#43725: 28.0.50; Include feature/native-comp into master
Date: Thu, 18 Feb 2021 20:32:06 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> Addressing some easy part of the review to close the day.
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> [...]
>> Several comparisons like this one:
>>
>>   +  if (val != (long) val)
>>
>> are IMO better written as
>>
>>   if (val > LONG_MAX || val < LONG_MIN)
>
> Fixed by 72e4a22391

I noticed that with the suggested fix applied in configurations where
'val' can't exceed a long on the positive side GCC (trunk from some time
ago) is complaining emitting the following warning:

comp.c:1174:22: warning: logical ‘or’ of collectively exhaustive tests is 
always true [-Wlogical-op]
 1174 |   if (val > LONG_MAX || val < LONG_MIN)
      |                      ^~

Not sure what's the best way to silence it or if we want to revert to
the previous formulation.

  Andrea





reply via email to

[Prev in Thread] Current Thread [Next in Thread]