[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48408: BUGFIX: window-default-font-height: check for nil string
From: |
martin rudalics |
Subject: |
bug#48408: BUGFIX: window-default-font-height: check for nil string |
Date: |
Fri, 14 May 2021 09:09:38 +0200 |
> In package windows.el, function `window-default-font-height' calls
> function `face-font', which can return a nil value, but performs a
> `string-equal' operation on the output without checking for that
> possibiliy.
Please report this to the author(s) of that package.
> I came across this in an unusual case, of having an 'emacs -nw' server
> an 'emacsclient -nw', and opening a GUI emacsclient to connect to it.
> From that point forward until the fix, every *second* attempt to use the
> minibuffer on the 'emacsclient -nw' would fail.
>
> The fix I'm using is:
>
> (if (and (display-multi-font-p (frame-parameter frame 'display))
> (stringp default-font) ; <<<---!!!
What is `default-font'?
> (not (string-equal (frame-parameter frame 'font) default-font)))
>
> But there could be other considerations to performing things in another way.
martin
- bug#48408: BUGFIX: window-default-font-height: check for nil string, (continued)
- bug#48408: BUGFIX: window-default-font-height: check for nil string, Boruch Baum, 2021/05/19
- bug#48408: BUGFIX: window-default-font-height: check for nil string, martin rudalics, 2021/05/19
- bug#48408: BUGFIX: window-default-font-height: check for nil string, Boruch Baum, 2021/05/19
- bug#48408: BUGFIX: window-default-font-height: check for nil string, Eli Zaretskii, 2021/05/19
- bug#48408: BUGFIX: window-default-font-height: check for nil string, Boruch Baum, 2021/05/19
- bug#48408: BUGFIX: window-default-font-height: check for nil string, Eli Zaretskii, 2021/05/19
- bug#48408: BUGFIX: window-default-font-height: check for nil string, Eli Zaretskii, 2021/05/19
- bug#48408: BUGFIX: window-default-font-height: check for nil string, martin rudalics, 2021/05/16
bug#48408: BUGFIX: window-default-font-height: check for nil string,
martin rudalics <=
bug#48408: BUGFIX: window-default-font-height: check for nil string, Boruch Baum, 2021/05/15