[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el
From: |
Stefan Monnier |
Subject: |
bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el |
Date: |
Sun, 23 May 2021 11:50:56 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
>> Clearly, this is not right: passthrough completion should pass the `str`
>> and `point` info to the completion table. The completion table may opt
>> to ignore that information, but we shouldn't prevent them from using it.
>> I expect most passthrough uses will want to use `str`.
>
> I see what you mean. In my use case I didn't use an improperly
> implemented completion table which does not ignore . However the
> question is then if this "passthrough" style is really needed since if
> you don't ignore the input, it is mostly equivalent to the emacs21 style.
The "passthrough" (elsewhere called "backend") completion-style is
definitely something we need to add, yes. But what it should do is pass
all the args from `completion-all/try-completions` to the table and let
the table do *all* the work, i.e. let the completion table implement the
completion-style methods. But we shouldn't call `all-completions` or
`try-completions` for that. Instead we should call the completion-table
directly, as is done for the `completion-boundaries` method.
Stefan
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, Daniel Mendler, 2021/05/21
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, Stefan Monnier, 2021/05/22
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, Daniel Mendler, 2021/05/23
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, Daniel Mendler, 2021/05/23
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el,
Stefan Monnier <=
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, João Távora, 2021/05/23
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, Daniel Mendler, 2021/05/23
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, Stefan Monnier, 2021/05/26
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, Daniel Mendler, 2021/05/29
- bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, Stefan Monnier, 2021/05/30
bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el, Dmitry Gutov, 2021/05/22