[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#19066: 25.0.50; nadvice and interactive-form
From: |
Stefan Monnier |
Subject: |
bug#19066: 25.0.50; nadvice and interactive-form |
Date: |
Mon, 31 May 2021 08:49:27 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars Ingebrigtsen [2021-05-31 07:43:34] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Another way would be to make the interactive form of the "compose
>> function" more dynamic: make it re-checks the interactive form of every
>> advice function every time. That's probably the better option.
> That sounds like a good solution to me -- the interactive path isn't
> normally performance critical, so adding more work in that case should
> be fine.
Yes, performance is not an issue. But preserving the semantics 100% is
currently somewhere between hard and impossible. 99.9% is fairly easy,
OTOH (IIRC the main problem has to do with how the args get represented
in `command-history`).
Stefan