[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers che
From: |
Lars Ingebrigtsen |
Subject: |
bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled |
Date: |
Fri, 04 Jun 2021 11:35:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Alex Bochannek <alex@bochannek.com> writes:
> Is there any documentation you would like to see before accepting this
> change?
I don't think the patch is the right thing to do:
diff --git a/lisp/gnus/gnus-int.el b/lisp/gnus/gnus-int.el
index 01053797b3..d2d7fd55ae 100644
--- a/lisp/gnus/gnus-int.el
+++ b/lisp/gnus/gnus-int.el
@@ -527,7 +527,11 @@ gnus-retrieve-headers
((and gnus-use-cache (numberp (car articles)))
(gnus-cache-retrieve-headers articles group fetch-old))
((and gnus-agent (gnus-online gnus-command-method)
- (gnus-agent-method-p gnus-command-method))
+ (gnus-agent-method-p gnus-command-method)
+ (not gnus-nov-is-evil)
So you're basically disabling the Agent when gnus-nov-is-evil is set,
and while it solves this problem, it's not a good general solution --
the two things are kinda-sort orthogonal. Instead you should just
exclude the nnvirtual component groups from the Agent.
+ (not (symbol-value
+ (intern
+ (format "%s-nov-is-evil" (car gnus-command-method))))))
(And this isn't correct anyway -- not all backends have a -nov-is-evil
variable).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Alex Bochannek, 2021/06/02
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Lars Ingebrigtsen, 2021/06/03
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Alex Bochannek, 2021/06/03
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled,
Lars Ingebrigtsen <=
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Alex Bochannek, 2021/06/04
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Lars Ingebrigtsen, 2021/06/06
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Alex Bochannek, 2021/06/06
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Lars Ingebrigtsen, 2021/06/08
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Alex Bochannek, 2021/06/08
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Alex Bochannek, 2021/06/09
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Lars Ingebrigtsen, 2021/06/09
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Alex Bochannek, 2021/06/09
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Eli Zaretskii, 2021/06/09
- bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled, Alex Bochannek, 2021/06/09