bug#48916: 28.0.50; allow windmove to select windows with the 'no-other-window parameter

[pillule]

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks.  I don't use windmove, so I will let others comment. 
> But
> please allow me a few minor nits:

Your ‘minor nits’ are indeed welcome.

> > * lisp/windmove.el
> >    (windmove-ignore-no-other-window): add this new user option
> >    (windmove-find-other-window): uses 
> >    windmove-ignore-no-other-window
> > to choose whether windmove can access to the window with the
> > 'no-other-window property.
>
> This isn't formatted accoring to our rules.  In particular, each
> sentence after the colon should begin with a capital letter and 
> end
> with a period.  See CONTRIBUTE for more details (and I suggest 
> to use
> Emacs commands for writing log messages, as they will take care 
> of
> some routine parts of the formatting for you).

So that means you are recommending to use VC instead of Magit 
(that I used) for committing changes ?
Maybe Magit have a something that I am not aware for this purpose 
?

> > +(defcustom windmove-ignore-no-other-window nil
>
> This name is not the best one.  For starters, "ignore-no" is a 
> kind of
> double negation, which makes it harder to understand and 
> remember.
> Can you come up with a better description of what exactly is 
> ignored
> here?

Yes, i think 'windmove-move-in-all-windows' will be more explicit.

> > +  "Whether the windmove commands are allowed to target all 
> > type of windows,
>
> The first line of a doc string should be a complete sentence (it 
> is)
> and end with a period.
>
> > +If this variable is set to t, 
> > `windmove-find-other-window--side' and
>    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> "If non-nil, ..."
>
> > +subsequently all interactive windmove commandswill ignore the
>                                          ^^^^^^^^^^^^
> A typo.
>
> > +no-other-window parameter."
>
> If you reference this parameter, I think you should say that 
> it's a
> parameter to be applied by display-buffer-alist's actions.
> > +  :type 'boolean
> > +  :group 'windmove)
>
> New defcustoms should have a :version tag.
> Also, I believe we don't  like redundant :group tags, such as 
> the one here.

got them. the last one may be a little bit confusing for the 
reader that is not aware of it because all others defcustoms of 
window.el applies a :group tag. Do you want that I remove the 
others unnecessary ones ?

0002-User-option-to-select-no-other-window-with-windmove.patch
Description: minor nits

--