[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#49069: 28.0.50; [PATCH] Use display-buffer for re-builder
From: |
Juri Linkov |
Subject: |
bug#49069: 28.0.50; [PATCH] Use display-buffer for re-builder |
Date: |
Thu, 08 Jul 2021 20:40:39 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
tags 49069 fixed
close 49069 28.0.50
thanks
> To be fair, blaming the different repositories gives no evidence that
> this macro is a reaction to perspective.el
Indeed, we don't know for sure, it was just a hypothesis.
But anyway such "catch-all" tricks as ".*" should be avoided.
Also I don't know if there is any chance to fix Org-mode.
Anyway, I'm using such workaround for Org-mode problem:
#+begin_src emacs-lisp
;; Unfortunately, Org window customization has no effect because
;; ‘display-buffer-alist’ is ignored in ‘org-no-popups’
;; until ‘org-switch-to-buffer-other-window’ is overridden below:
(defalias 'org-switch-to-buffer-other-window 'switch-to-buffer-other-window)
;; This allows such user customizations:
(push '("\\`\\*Org \\(Links\\|Select\\)\\*\\'"
display-buffer-below-selected
(window-height . fit-window-to-buffer)
(preserve-size . (nil . t)))
display-buffer-alist)
#+end_src
> Ok you convinced me. Thanks for the tip, I installed it on a low-vision
> setup of a knowledge of me. We will see more in detail the differences
> that it implies.
>
> So it seems that the patch of the Thu, 17 Jun 2021 16:50:07 +0200
> was indeed the one we want to keep.
>
> I tested it again, with :
>
> (customize-set-variable
> 'display-buffer-base-action
> '((display-buffer-reuse-window display-buffer-same-window)))
>
> (setf (alist-get "*RE-Builder*" display-buffer-alist nil nil #'string=)
> `((display-buffer-in-direction)
> (direction . top)
> (dedicated . t)))
>
> (re-builder)
>
> And it obeys to display-buffer-alist, be it for an other
> function or others parameters, and keep being functional ... etc.
Thanks for confirming and for implementing the patch.
Now your patch was pushed in commit 57354bc64b.
bug#49069: 28.0.50; [PATCH] Use display-buffer for re-builder, Constantine Vetoshev, 2021/07/08