bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#49624: compilation message end-column function off-by-one bug


From: Mattias Engdegård
Subject: bug#49624: compilation message end-column function off-by-one bug
Date: Sun, 18 Jul 2021 21:00:41 +0200

Compilation message patterns (in compilation-regexp-alist and -alist) can 
indicate starting and ending line and column numbers, either by supplying 
regexp match numbers or functions that return the respective line/column 
numbers when called. In other words, the integer N can be understood as a 
shorthand for the function

(lambda () (and (match-beginning N) (string-to-number (match-string N))))

except that isn't true for the ending column where there is a difference of 1; 
an END-COL function returning 13 means that the error's last column is 12.

There does not seem to be a good justification for this nor is it documented so 
it's probably just a bug; proposed patch attached below. Does it warrant a 
mention in etc/NEWS?

Attachment: 0001-Fix-off-by-one-error-in-compilation-rule-end-column-.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]