[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map
From: |
Brian Leung |
Subject: |
bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map |
Date: |
Sat, 24 Jul 2021 05:33:50 +0200 (CEST) |
OK, I've updated the patch following Juri's suggestions.
> ----------------------------------------
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Sent: Mon Jul 19 17:52:43 CEST 2021
> To: Juri Linkov <juri@linkov.net>
> Cc: Brian Leung <leungbk@mailfence.com>, <49632@debbugs.gnu.org>
> Subject: Re: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map
>
>
> Juri Linkov <juri@linkov.net> writes:
>
> > Exactly. But this means that you need to populate a new separate map
> > 'gdb-repeat-map' specific to 'gdb' commands. Also I noticed that the
> > current name of 'gud-repeat-map' is wrong. It should be renamed to
> > 'gud-gdb-repeat-map'. So other debuggers could populate own repeat-maps
> > named e.g. 'sdb-repeat-map', 'jdb-repeat-map', 'perldb-repeat-map', etc.
>
> I see. Then Brian's patch is functionally correct, but it shouldn't be
> copy-and-pasted -- instead separating it out into a helper function and
> using it both places seems like the correct thing to do.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
--
Sent with https://mailfence.com
Secure and private email
--
Mailfence.com
Private and secure email
0001-Ensure-that-gud-commands-for-M-x-gdb-are-handled-by-.patch
Description: File Attachment: 0001-Ensure-that-gud-commands-for-M-x-gdb-are-handled-by-.patch
0002-Ensure-that-gud-commands-for-non-GDB-debuggers-are-h.patch
Description: File Attachment: 0002-Ensure-that-gud-commands-for-non-GDB-debuggers-are-h.patch
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Brian Leung, 2021/07/18
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Brian Leung, 2021/07/19
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Juri Linkov, 2021/07/19
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Lars Ingebrigtsen, 2021/07/19
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map,
Brian Leung <=
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Lars Ingebrigtsen, 2021/07/25
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Juri Linkov, 2021/07/25
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Brian Leung, 2021/07/25
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Juri Linkov, 2021/07/26
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Brian Leung, 2021/07/27
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Brian Leung, 2021/07/27
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Juri Linkov, 2021/07/27
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Eli Zaretskii, 2021/07/28
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Juri Linkov, 2021/07/28
- bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map, Eli Zaretskii, 2021/07/28