bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Marius Kjeldahl]

Still does NOT seem to work, sorry about that.

Thanks,

Marius K.

On Sun, Jul 25, 2021 at 11:14 PM Marius Kjeldahl
<marius.kjeldahl@gmail.com> wrote:
>
> I rebuilt emacs from head (brew reinstall emacs-head@28 --with-cocoa
> --with-native-comp) and it still does seem to work.
>
> If I set four bookmarks and then delete all bookmarks, only the last
> one set will actually be cleaned up visually. Even though there are no
> active bookmarks any longer, the three first will still have
> highlighted lines.
>
> Thanks,
>
> Marius K.
>
> On Sun, Jul 25, 2021 at 4:34 PM Christopher League
> <league@contrapunctus.net> wrote:
> >
> > Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:
> >
> > > A few months ago highlighting the bookmark lines got turned on
> > > by default. While it's possible to delete bookmarks, the
> > > highlighting seems to remain stuck. Setting and clearing many
> > > temporary bookmarks while working in code means the the code
> > > gets littered with such highlights. I haven't found any way of
> > > cleaning up those highlights, except killing the buffer and
> > > reloading the file. I've turned it off by setting
> > > bookmark-fontify. But surely, the current behaviour must be
> > > considered a bug.
> >
> > Hi Marius,
> >
> > I think today we committed a fix for this issue of stuck bookmark
> > highlights:
> > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=142961bcdfb202ca3347a085e55c87b164bb2fb9
> >
> > Can you confirm that it resolves the problem you saw?
> >
> > If you're not building from git regularly, you should be able to
> > just download the most recent bookmark.el from here and
> > ‘eval-buffer’ it to test:
> > https://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/bookmark.el
> >
> > In my analysis, clearing the highlight worked previously when
> > using ‘bookmark-delete’, but not when overwriting an existing
> > bookmark with a new location. The current version should fix it.
> > Thanks.
> >
> > CL