[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50038: Permanent shift-select-mode
From: |
Juri Linkov |
Subject: |
bug#50038: Permanent shift-select-mode |
Date: |
Fri, 13 Aug 2021 10:04:27 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
It's very convenient to use a shift-translated key to activate the region,
because e.g. 'S-C-f' requires typing less keys than 'C-SPC C-f'.
But when there is a need to extend the region by typing a navigation key
that is not shift-translated, it abruptly deactivates the region.
The current default behavior was implemented in such unusable way
because "other apps" behave the same way.
So the following patch provides an option for the behavior that is more
convenient than in "other apps":
diff --git a/lisp/simple.el b/lisp/simple.el
index 25a5a166e8..d951570937 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -6649,9 +6649,15 @@ shift-select-mode
by any subsequent point motion key that was not shift-translated, or
by any action that normally deactivates the mark in Transient Mark mode.
+When the value is `permanent', the mark will not be deactivated
+by any subsequent point motion key that was not shift-translated.
+
See `this-command-keys-shift-translated' for the meaning of
shift-translation."
- :type 'boolean
+ :type '(choice (const :tag "Off" nil)
+ (const :tag "Permanent" permanent)
+ (other :tag "On" t))
+ :version "28.1"
:group 'editing-basics)
(defun handle-shift-selection ()
@@ -6669,7 +6675,12 @@ handle-shift-selection
Otherwise, if the region has been activated temporarily,
deactivate it, and restore the variable `transient-mark-mode' to
its earlier value."
- (cond ((and shift-select-mode this-command-keys-shift-translated)
+ (cond ((and (eq shift-select-mode 'permanent)
+ this-command-keys-shift-translated)
+ (unless mark-active
+ (push-mark nil nil t)))
+ ((and shift-select-mode
+ this-command-keys-shift-translated)
(unless (and mark-active
(eq (car-safe transient-mark-mode) 'only))
(setq-local transient-mark-mode
- bug#50038: Permanent shift-select-mode,
Juri Linkov <=