[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `grou
From: |
João Távora |
Subject: |
bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function` |
Date: |
Thu, 19 Aug 2021 20:41:38 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 19.08.2021 14:18, João Távora wrote:
>> completion-all-sorted-completions in minibuffer.el if a table supplies
>> `group-function`. A patch for this is after my sig.
>
> We discussed this problem when group-function was introduced. Another
> approach is to just change the method of grouping: first the
> completions are sorted, and then they are sorted into groups.
That's a possiblity. But it might be performing too much work, at least
at first sight. For the C-x 8 RET case and the xref table (the only
tables I know which use this) things seem to be naturally put into
groups already. So sorting them alphabetically, by length, by history,
and _then_ destroying most (but not all) with the grouping could be not
so interesting if the there's a big a price to pay.
I recommend whatever is done that some quantitative benchmarking is
performed to the before/after. Enabling fido-vertical-mode and pressing
C-u C-x C-e C-m after
(benchmark-run (call-interactively 'insert-char))
Seems to be a decent way to measure.
Currently, with the alpha/length/history sorting, it takes about 1
second in my machine. Without any sorting (and the natural grouping),
takes about 0.6 seconds. You should measure what the re-grouping
sorting does.
João
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, João Távora, 2021/08/17
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, Kévin Le Gouguec, 2021/08/18
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, Dmitry Gutov, 2021/08/19
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`,
João Távora <=
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, Dmitry Gutov, 2021/08/19
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, João Távora, 2021/08/19
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, Dmitry Gutov, 2021/08/19
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, João Távora, 2021/08/20
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, Dmitry Gutov, 2021/08/20
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, João Távora, 2021/08/21
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, Dmitry Gutov, 2021/08/21
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, João Távora, 2021/08/21
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, Dmitry Gutov, 2021/08/22
- bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`, João Távora, 2021/08/22