bug#7221: timestamp in cvs-quickdir on Win32 system

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> I don't think I agree.  My reading of the relevant CVS code is that
> CVS uses either 'asctime' or 'ctime' to produce the time string for
> "Entries", and 'asctime'/'ctime' always produce the standard format of
> the time, not the locale-preferred format produced by %c.  See
> vers_ts.c:time_stamp in the CVS sources.
>
> FWIW, I see the same problem on my MS-Windows machine.

Does the proposed patch fix the issue, then?  It removes the "%c" and
uses a more standard date format:

diff --git a/lisp/vc/pcvs-info.el b/lisp/vc/pcvs-info.el
index 9f8a168a0a..5a607e337b 100644
--- a/lisp/vc/pcvs-info.el
+++ b/lisp/vc/pcvs-info.el
@@ -454,7 +454,8 @@ cvs-fileinfo-from-entries
               ((let ((mtime (file-attribute-modification-time
                              (file-attributes (concat dir f))))
                      (system-time-locale "C"))
-                 (setq timestamp (format-time-string "%c" mtime t))
+                 (setq timestamp (format-time-string "%a %b %e %H:%M:%S %Y"
+                                                      mtime t))
                  ;; Solaris sometimes uses "Wed Sep 05", not "Wed Sep  5".
                  ;; See "grep '[^a-z_]ctime' cvs/src/*.c" for reference.
                  (if (= (aref timestamp 8) ?0)



-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no