bug#50410: Tramp does not honor default file modes in make-directory

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Stephen,
>
>> Tramp: honor default file modes in make-directory
>
> Thanks for this. As discussed privately, I believe it is a good
> extension to Tramp.
>
> I gave it a short try, and it works as expected for the "mock" test
> method. Please push to the master branch; perhaps you could also add a
> short NEWS entry.
>
> Next days I let run the test suite for the other Tramp methods.

The results are good. In tramp-test13-make-directory-with-file-modes
I have applied the same rules like in tramp-test20-file-modes, it looks now

--8<---------------cut here---------------start------------->8---
(ert-deftest tramp-test13-make-directory-with-file-modes ()
  "Check that `make-directory' honors `default-file-modes'.
This is a separate test from `tramp-test13-make-directory' because
some backends cannot pass this test."
  (skip-unless (tramp--test-enabled))
  (skip-unless
   (or (tramp--test-sh-p) (tramp--test-sshfs-p) (tramp--test-sudoedit-p)
       ;; Not all tramp-gvfs.el methods support changing the file mode.
       (and
        (tramp--test-gvfs-p)
        (string-match-p
         "ftp" (file-remote-p tramp-test-temporary-file-directory 'method)))))
  (tramp-test-make-directory-helper t))
--8<---------------cut here---------------end--------------->8---

In tramp-adb.el I believe it would work as well, if the Android device
is rooted. But this we don't support.

>From my POV, you could push it to master.

Best regards, Michael.