bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled o


From: Kirill A. Korinsky
Subject: bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS
Date: Tue, 14 Sep 2021 16:17:15 +0200

Hey,

I can't broke the nuclear option anymore.

Seems it fixing everything.

-- 
wbr, Kirill

On 14. Sep 2021, at 14:13, Alan Third <alan@idiocy.org> wrote:

On Tue, Sep 14, 2021 at 01:26:44PM +0200, Kirill A. Korinsky wrote:
I have one bad news: it still exists but less often.

I can reproduce it one time in 10 starts of my emacs.

The *only* place that should modify FRAME_EXTERNAL_TOOL_BAR is
ns_set_tool_bar_lines, which should be called *every time* the number
of lines is changed.

It would be nice to know what the value of FRAME_EXTERNAL_TOOL_BAR and
tool-bar-lines are when the toolbar is wrongly visible, because I
can't find a single location in the code that sets the visibility
without first checking FRAME_EXTERNAL_TOOL_BAR, and it should *always*
be set by ns_set_tool_bar_lines.

*sigh* I've no idea.

Attached is the nuclear option. If this doesn't work then
FRAME_EXTERNAL_TOOL_BAR is wrong.

--
Alan Third
<0001-A-further-fix-for-toolbar-visibility-problems-on-mac.patch>

Attachment: signature.asc
Description: Message signed with OpenPGP


reply via email to

[Prev in Thread] Current Thread [Next in Thread]