bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50690: Avoid double argument evaluation in vc-call


From: Basil L. Contovounesios
Subject: bug#50690: Avoid double argument evaluation in vc-call
Date: Tue, 21 Sep 2021 12:53:43 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

close 50690 28.1
quit

Lars Ingebrigtsen [2021-09-21 07:18 +0200] wrote:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Is there any reason why the macro vc-call should continue to evaluate
>> its second argument twice?  Both 'make bootstrap' and 'make check' pass
>> with the attached patch:
>
> Your patch seems "obviously correct" to me (but it's an incompatible
> change since the previous wonky behaviour was actually documented, so it
> should be mentioned in NEWS).

Done:

Avoid double argument evaluation in vc-call macro
5b962a7ad8 2021-09-21 12:30:58 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=5b962a7ad8d0acfe40a41ce139059b9c8e46f666

I wasn't sure which is the most appropriate heading for it, so I put it
under

  * Changes in Specialized Modes and Packages in Emacs 28.1
  ** Change Logs and VC

Would

  * Incompatible Lisp Changes in Emacs 28.1

be more appropriate?

Thanks,

-- 
Basil





reply via email to

[Prev in Thread] Current Thread [Next in Thread]