[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50777: Dropping EIEIO from xref (for performance)
From: |
Dmitry Gutov |
Subject: |
bug#50777: Dropping EIEIO from xref (for performance) |
Date: |
Sun, 26 Sep 2021 04:15:27 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 24.09.2021 18:32, Dmitry Gutov wrote:
One area of bigger concern is whether code compiled against the new
version of Xref would work with the old one without recompiling (and
vice versa). I guess for that to work we need to disable inlining on
xref-item's accessors, at least. Maybe there's something else I'm missing.
OK, so I've done some testing with ivy-xref (fixing it to stop using
with-slots), and (:noinline t) indeed seems necessary for Emacs using
previous version of xref to run code from ivy-xref.elc compiled with the
newer version without errors.
But since I tested this in Emacs 27,
(void-function make-closure)
was a much bigger problem. This is apparently how lambdas are compiled now.
So this is a +1 minor reason to release the new version together with
Emacs 28: less need to worry about :noinline. Though we could use it
anyway, to avoid tying byte code to a particular implementation: the
performance seems unchanged.
bug#50777: Dropping EIEIO from xref (for performance), Arthur Miller, 2021/09/24
bug#50777: Dropping EIEIO from xref (for performance), Lars Ingebrigtsen, 2021/09/24
bug#50777: Dropping EIEIO from xref (for performance), Daniel Martín, 2021/09/25
bug#50777: Dropping EIEIO from xref (for performance), Dmitry Gutov, 2021/09/30