bug#50007: 28.0.50; normalize logic surrounding erc-server-reconnecting

[J.P.]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> "J.P." <jp@neverwas.me> writes:
>
>> Subject: [PATCH] Normalize usage of variable erc-server-reconnecting
>
> I think I managed to follow the logic of this change, and it doesn't
> seem to regress anything after a bit of testing, so I've pushed it to
> Emacs 29.

Thanks Lars. As you may recall, I'm quite slow, often in more ways than
one. And that certainly applies here. Turns out I've been sitting on
slightly revised versions of both this and

  bug#50008: 28.0.50; ERC sends empty lines with user input

which you also recently added. For some reason (not sloth/dimwittedness,
I assure you), I only updated the versions of these patches living in
#48598 but neglected to follow suit with these two threads. So with much
contrition, I've isolated the differences and attached them here.

The updates to this bug attempt to preserve a couple API elements I
ditched/clobbered in what's already been installed (in the unlikely
event some poor sap or bot actually depended on them). This is mainly an
effort to embrace the spirit of being more responsible with and
accountable for my changes, something I've been slow to pick up on from
the great bandali. That said, I totally understand if you'd rather I
learn to live with my mistakes as well.

The minor changes to the other, "empty lines" patch just involve another
instance of superfluous newlines, this time generated from the function
`erc-cmd-default'. Thanks again and sorry for the disturbance.

0001-Deprecate-instead-of-redefine-erc-server-reconnectin.patch
Description: Text Data

0002-Don-t-send-empty-lines-for-unknown-commands-in-ERC.patch
Description: Text Data