[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-repl
From: |
Juri Linkov |
Subject: |
bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc. |
Date: |
Mon, 10 Jan 2022 21:09:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
> I attached a new patch (still a sketch) that requires no changes in
> comint.el and simple.el. Perhaps you will find this approach more
> acceptable.
Thanks, no changes in other files is certainly a big plus.
>> It would be great to use your new variable with a function
>> to show replacement counts in perform-replace. IIUC,
>> let-binding isearch-lazy-count-display-function to
>> isearch-read-with-highlight-count will suppress isearch-message?
>
> I tried this and it's relatively simple to do, but there is a problem.
> Suppose you want to replace all "a" with "z", and your buffer has 20
> "a"s initially. Then, as you keep hitting "y" to confirm a replacement
> the count will be
>
> 1/20, 1/19, ..., 1/1
This is an interesting question. I tried in other editors,
and e.g. in the editor xed that is installed by default,
this is exactly what is displayed: 1/20, 1/19, ..., 1/1.
> since the number of "a"s decrease, and the point is always at the first
> of the still-existing ones. But probably one should count the number of
> prompts, so
>
> 1/20, 2/20, ..., 20/20
>
> I think this means `perform-replace' has to implement its own way to
> display a count.
Maybe this makes more sense, when the users will learn
what do these numbers mean.
>> I meant using simply
>>
>> (add-hook 'minibuffer-setup-hook 'isearch-read-with-highlight-setup)
>>
>> But it seems isearch-read-with-highlight-setup doesn't set
>> isearch-lazy-count-display-function.
>
> I guess this could be done.
Maybe two separate hooks could be defined? One highlights like
lazy-highlight, and another counts like lazy-count does:
(add-hook 'minibuffer-setup-hook 'isearch-read-with-highlight-setup)
(add-hook 'minibuffer-setup-hook 'isearch-read-with-count-setup)
> But note that there are two possible types
> of counts: a "current/total" counter or just a "total" counter. Each
> use case calls for a different count style.
The format of the total counter needs to be defined in a separate variable.
> By the way, I'm debating a bit whether
> `isearch-lazy-count-display-function' should be:
>
> 1. Either nil or function, as it is right now,
> 2. #'ignore by default, so similar to 1) but a bit easier to use with
> `add-function'
> 3. a hook, the main inconvenience being that it can't be easily let-bound.
This can be answered only by testing with all possible cases ;-)
- bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc., Augusto Stoffel, 2022/01/08
- bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc., Juri Linkov, 2022/01/08
- bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc., Augusto Stoffel, 2022/01/08
- bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc., Juri Linkov, 2022/01/09
- bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc., Augusto Stoffel, 2022/01/09
- bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc., Augusto Stoffel, 2022/01/09
- bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc., Juri Linkov, 2022/01/09
- bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc., Augusto Stoffel, 2022/01/10
- bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc.,
Juri Linkov <=